-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add node-problem-detector #870
Add node-problem-detector #870
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a rebase, and might be worth porting to TF if possible.
bfb1e30
to
d68bdb5
Compare
Rebased and ported to TF. Could you please check? @imjasonh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to have it included in main.tf too
0606c50
to
15289fd
Compare
Rebased. |
Signed-off-by: Furkan <[email protected]> Co-authored-by: Batuhan <[email protected]>
15289fd
to
1d38a72
Compare
a9c6472
to
c8f8f13
Compare
c8f8f13
to
257a52f
Compare
Signed-off-by: Batuhan Apaydin <[email protected]>
257a52f
to
602ec0f
Compare
busybox
in the runtime (AFAIK, npd calls some binaries in the runtime), so binary size increased134MB
->145MB
178 packages, 121 vulnerabilities
to122 packages, 17 vulnerabilities
(Benchmark image: registry.k8s.io/node-problem-detector/node-problem-detector:v0.8.13)
Any dependency we bump here breaks the compatibility directly.
Fixes:
Related:
Pre-review Checklist
Quality Requirements for Images PRs
The items in this checklist should all be checked in the PR with exceptions clearly documented.
The general idea is that to the extent possible, the image should be a drop-in replacement to its public counterpart.
For new image PRs only
If you have an apko.yaml file in this PR you need to follow this checklist, otherwise feel free to remove.
Include tests, sufficient enough that you would trust this image running in production.
Perform manual tests as needed and document your testing results
The version included is the latest GA version of the software
The latest tag points to the newest stable version
There is a dev tag available that includes a shell and apk tools (by depending on 'wolfi-base')
The image runs as
nonroot
and GID/UID are set to 65532 or upstream defaultThe image contains the ca-certs bundle if needed
ENTRYPOINT
CMD:
–help
Add annotations e.g:
docker kill $(docker run -d --rm cgr.dev/chainguard/nginx)
Documentation Requirements