minor go cleanup and some performance improvements #1730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajayk
force-pushed
the
minor-cleanup
branch
2 times, most recently
from
bc00f2c to
b52ef50
Compare
ajayk
changed the title
jonjohnsonjr
reviewed
Jan 6, 2025
Co-authored-by: Jon Johnson <[email protected]> Signed-off-by: Ajay Kemparaj <[email protected]>
Co-authored-by: Jon Johnson <[email protected]> Signed-off-by: Ajay Kemparaj <[email protected]>
jonjohnsonjr
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor improvements on sha validations
sample benchmark code https://gist.github.com/ajayk/869fedfbcdb0a64444858c14de7c7a31
Results here