-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fetch: check a cache directory for files matching expected SHAs #143
Conversation
This passes tests, but it doesn't actually work. |
8f135a4
to
e2dfd20
Compare
This should work now. I can try to add an e2e test that populates and exercises the cache, but it may be tough to prove it doesn't hit the network in GitHub Actions. |
This adds a --cache-dir flag (default /var/cache/melange), which is bound into the build environment at /var/cache/melange (constant), and updates the fetch.yaml pipeline to look for files matching the expected-sha{256,512} in that directory. The intention is that builds could pre-fetch external dependencies into the cache directory, then execute builds without hitting the network. If --cache-dir doesn't exist, it's not bound and fetch will always wget. Also adds CI checks to build all examples. Signed-off-by: Jason Hall <[email protected]>
Signed-off-by: Jason Hall <[email protected]>
Signed-off-by: Jason Hall <[email protected]>
Signed-off-by: Jason Hall <[email protected]>
Signed-off-by: Jason Hall <[email protected]>
We can ask bubblewrap to unshare the network namespace. |
Ooh! A new flag for melange that passes |
This adds a
--cache-dir
flag (default"/var/cache/melange"
), which is bound into the build environment at/var/cache/melange
(constant), and updates the fetch.yaml pipeline to look for files matching theexpected-sha{256,512}
in that directory.The intention is that builds could pre-fetch external dependencies into
the cache directory, then execute builds without hitting the network.
If --cache-dir doesn't exist, it's not bound and fetch will always wget.
Also adds CI checks to build all examples.
Fixes #144