Ignore JSON files, except for NPM package.json files #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tstromberg
changed the title
imjasonh
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we added support for scanning NPM package.json files (https://docs.npmjs.com/cli/v10/configuring-npm/package-json), we enabled scanning for all JSON files.
It turns out a lot of JSON files are just grab-bag lists of weird strings, and we trigger on them thinking they are full of all sorts of malicious content. This PR updates the filetype logic so that we only return a parseable file-type if the JSON file ends with "*package.json".
NOTE: This default still be overridden by passing
--allon the command-line.