Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor YARA rule tuning based on upcoming talk #673

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

tstromberg
Copy link
Collaborator

@tstromberg tstromberg commented Dec 3, 2024

  • Add queries to improve results for wiper/exfil examples presented
  • Remove collect/databases/sql rule: too many falses-positives, including xz-utils.
  • Remove fullword restriction from ssh private key detection as it doesn't work well with Go strings that aren't null terminated.
  • raise arbitrary_command_dev_null from medium to high

Fixes not shown in the presentation, but noticed while preparing for it:

  • Lower criticality of looser "CRITICAL" rules to "HIGH".
  • genericize yarn exception to exec/cmd/npm_preinstall

@tstromberg tstromberg requested a review from r0cketlad December 3, 2024 02:51
@tstromberg tstromberg changed the title Minor rule tuning based on upcoming talk Minor YARA rule tuning based on upcoming talk Dec 3, 2024
@tstromberg tstromberg enabled auto-merge (squash) December 3, 2024 02:51
@tstromberg tstromberg requested a review from egibs December 3, 2024 11:51
@tstromberg
Copy link
Collaborator Author

adding @philroche @imjasonh so they can see how the sausage is made; admittedly this rule update ended up veering around a bit, but it's pretty typical of the type of rule tuning we do when we analyze a new set of malicious samples.

@tstromberg tstromberg merged commit ff1e0a0 into chainguard-dev:main Dec 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants