Better handling of diffs between archives #626
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes some improvements around diffing entire archives. Previously, determining the relative path between the original location of the archive and the extracted files in the temporary directory essentially did not work.
I also modified how paths are represented when displaying the diff regardless of the files being diffed. Instead of displaying relative path -> actual path, we just show actual paths for both now which looks cleaner.
That said, this PR doesn't address the findings in #599 since we're still comparing mismatched map keys in cases like
ls
andls.x86_64
(or any equivalent filenames with different extensions).Examples: