Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MalwareBehaviorCatalog follow-up: less naming stutter, less slashes #558

Merged
merged 14 commits into from
Nov 1, 2024

Conversation

tstromberg
Copy link
Collaborator

Slashes are now only in rule names to show directory hierarchy - this removes the - to / conversion.

@tstromberg tstromberg marked this pull request as draft November 1, 2024 11:10
@tstromberg tstromberg marked this pull request as ready for review November 1, 2024 13:27
@tstromberg tstromberg requested a review from egibs November 1, 2024 13:27
@tstromberg
Copy link
Collaborator Author

lint error is intentional and dumb: artefacts appears as a name in the YARAForge signatures.

@egibs
Copy link
Member

egibs commented Nov 1, 2024

lint error is intentional and dumb: artefacts appears as a name in the YARAForge signatures.

Can we start excluding certain words?

https://docs.getwoke.tech/ignore/#in-line-and-next-line-ignoring
⬇️

func main() {
  fmt.Println("here is the whitelist") // wokeignore:rule=whitelist

  // wokeignore:rule=blacklist
  fmt.Println("and here is the blacklist")
}

@tstromberg
Copy link
Collaborator Author

lint error is intentional and dumb: artefacts appears as a name in the YARAForge signatures.

Can we start excluding certain words?

https://docs.getwoke.tech/ignore/#in-line-and-next-line-ignoring ⬇️

func main() {
  fmt.Println("here is the whitelist") // wokeignore:rule=whitelist

  // wokeignore:rule=blacklist
  fmt.Println("and here is the blacklist")
}

Yeah, I think we should kill this linter and do it through golangci-lint instead though. The fact that we have lint checks that aren't run locally is dumb and frustrating.

@tstromberg tstromberg enabled auto-merge (squash) November 1, 2024 15:29
@tstromberg tstromberg merged commit fffd138 into chainguard-dev:main Nov 1, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants