Add filesize condition to linux_multi_persist rule #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: egibs <[email protected]>
tstromberg
approved these changes
Oct 12, 2024
Good point. I'll rework the PR to add the filesize limit which will make the override moot. |
Signed-off-by: egibs <[email protected]>
egibs
changed the title
egibs
commented
Oct 12, 2024
| @@ -14,5 +14,5 @@ rule linux_multi_persist : critical { | |||
| $bash_ref6 = "/etc/bashrc" | |||
| $bash_ref7 = "/etc/bash" | |||
| condition: | |||
| ($initd or $udev) and $crontab and any of ($bash*) | |||
| filesize < 20MB and ($initd or $udev) and $crontab and any of ($bash*) | |||
There was a problem hiding this comment.
$ go run cmd/mal/mal.go analyze ./out/gitaly
🔎 Scanning "./out/gitaly"
out/gitaly [🔥 HIGH]
Signed-off-by: egibs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for: wolfi-dev/os#30457
This PR initially added a Gitaly override rule for
linux_persist_multibut now adds afilesize < 20MBcondition which will automatically ignore larger files (gitalywas ~270-280MB).