Delay rule compilation and cache the results #490
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves rule compilation until the last possible moment and caches the result.
This ensures that path typos such as
mal scan ./nonexistent
return an error instantly instead of compiling the rules first.Some example performance improvements:
mal xyz
: 40X fastermal scan ./nonexistent
: 25X fastermake test
: 9X fasterThis does not improve the result of
mal scan /path/to/malcontent-samples
however.