Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Seq2seq example #63

Merged
merged 62 commits into from
Aug 31, 2017
Merged

Add Seq2seq example #63

merged 62 commits into from
Aug 31, 2017

Conversation

keisukefukuda
Copy link
Member

No description provided.

@iwiwi iwiwi added the example label Jul 31, 2017
@@ -0,0 +1,32 @@
# ChainerMN seq2seq example

An sample implementation of seq2seq model.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An sample -> A sample

## Run

```bash
$ cd $CHAINERMN
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need a little more lines to run the script 😉

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed!

print('Num Minibatch-size: {}'.format(args.batchsize))
print('==========================================')

if False:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just in case: remove this before merge

# trainer.extend(translate, trigger=(200, 'iteration'))

# trainer.extend(CalculateBleu(model, test_data),
# trigger=(10, 'iteration'))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove unused code

@keisukefukuda keisukefukuda changed the title [WIP] Add Seq2seq example Add Seq2seq example Aug 30, 2017
@iwiwi
Copy link
Contributor

iwiwi commented Aug 31, 2017

Do we need seq2seq.orig.py here?

@keisukefukuda keisukefukuda changed the base branch from master to allreduce_persistent August 31, 2017 09:24
@keisukefukuda keisukefukuda changed the base branch from allreduce_persistent to master August 31, 2017 09:24
@iwiwi
Copy link
Contributor

iwiwi commented Aug 31, 2017

LGTM

@iwiwi iwiwi merged commit f23864a into master Aug 31, 2017
@iwiwi iwiwi deleted the seq2seq branch August 31, 2017 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants