Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs in DoubleBufferingOptimizer and PureNcclCommunicator #201

Merged
merged 3 commits into from
Feb 2, 2018
Merged

Fix bugs in DoubleBufferingOptimizer and PureNcclCommunicator #201

merged 3 commits into from
Feb 2, 2018

Conversation

shu65
Copy link
Member

@shu65 shu65 commented Jan 29, 2018 •
edited
Loading

I fixed bugs in DoubleBufferingOptimizer and PureNcclCommunicator.
Current double buffering feature has two bugs.

  1. runs actual_optimizer.update() when it is not required. This bug occurs when model is changed dynamically.
  2. doesn't wait for GPU process on default stream after pack_params.

I fixed them.

@shu65 shu65 changed the title Fix the bug in DoubleBufferingOptimizer Fix bugs in DoubleBufferingOptimizer Jan 31, 2018
@shu65 shu65 changed the title Fix bugs in DoubleBufferingOptimizer Fix bugs in DoubleBufferingOptimizer and PureNcclCommunicator Jan 31, 2018
@shu65 shu65 added this to the v1.2.0 milestone Feb 1, 2018
@iwiwi iwiwi added the bug label Feb 2, 2018
@iwiwi iwiwi self-requested a review February 2, 2018 04:50
@iwiwi iwiwi self-assigned this Feb 2, 2018
@iwiwi
Copy link
Contributor

iwiwi commented Feb 2, 2018

LGTM

@iwiwi iwiwi merged commit b711f47 into master Feb 2, 2018
@iwiwi iwiwi deleted the dbuf branch February 2, 2018 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwiwi iwiwi Awaiting requested review from iwiwi

Assignees

@iwiwi iwiwi

Labels
bug
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@shu65 @iwiwi