Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mean_absolute_error with ignore_nan option #193

Merged
merged 25 commits into from
Jun 26, 2018

Conversation

mottodora
Copy link
Member

@mottodora mottodora commented Jun 21, 2018

Please merge after #190

Copy link
Member

@corochann corochann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after #190 is merged.

check_forward_ignore_nan_with_nonnan_value(inputs)


def test_forward_gpu(inputs):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please put
@pytest.mark.gpu

@codecov-io
Copy link

codecov-io commented Jun 22, 2018

Codecov Report

Merging #193 into master will increase coverage by 0.93%.
The diff coverage is 88.71%.

@@            Coverage Diff             @@
##           master     #193      +/-   ##
==========================================
+ Coverage   76.64%   77.57%   +0.93%     
==========================================
  Files          87       91       +4     
  Lines        3712     4040     +328     
==========================================
+ Hits         2845     3134     +289     
- Misses        867      906      +39

@corochann
Copy link
Member

Let me merge!

@corochann corochann merged commit 9e0f4a9 into chainer:master Jun 26, 2018
@mottodora mottodora deleted the mae-ignore-nan branch June 27, 2018 07:23
@mottodora mottodora added this to the 0.4.0 milestone Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants