Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Component package manager #26

Closed
wants to merge 3 commits into from

Conversation

jamestalmage
Copy link

Add support for Component package manager by @visionmedia and the rest of the @component team.

@domenic
Copy link
Collaborator

domenic commented Jul 19, 2013

I have no interest in supporting hipster package managers who can't deal with package.json.

@tj
Copy link

tj commented Jul 19, 2013

haha didn't know a package manager could be hipster, all hail the frail package.json

@vendethiel
Copy link

I have no interest in supporting hipster package managers who can't deal with package.json.

because trolling definitely helps solving the issue anyway. It's not like we all had this conversations 15 times per package manager, is it ?

@tj
Copy link

tj commented Jul 19, 2013

@jamestalmage can always fork if the project isn't updated regularly (looks like it's not), at least we're not stuck with sinon-chai-2 etc like package.json ;)

@jamestalmage
Copy link
Author

Fork is done already (jamestalmage/sinon-chai) and I will try and keep it up to date.

@domenic: I am going to echo here what I said on sinonjs/sinon#307

I would urge you to at least reconsider the way you are detecting the CommonJS environment, as I don't think typeof module == 'object' is the best way. In the Component environment, module is a function.

From the CommonJS Spec:

3. In a module, there must be a free variable "module", that is an Object.

However, since function(){} instanceof Object == true, I would argue that Components implementation is still conformant.

If you agree to that change, adding the component.json file is fairly trivial and all that is necessary to support Component. I will maintain a fork that includes Component support no matter what, but changing how you detect CommonJS would make my life a bunch easier (and better match the spec IMO).

@tj
Copy link

tj commented Jul 19, 2013

FWIW I totally understand not wanting to maintain more cruft, I'd do the same for the other variants, but let's not talk about hipster tech, node itself is way up there haha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants