Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update include assertion docs for object properties #610

Merged
merged 1 commit into from
Feb 8, 2016

Conversation

wbyoung
Copy link
Contributor

@wbyoung wbyoung commented Feb 8, 2016

Originally added in #230, asserting that an object contains a subset of properties and values was never documented. Questions like #193 have popped up asking for this feature even though it's been present since 1.9.0.

The discussion in #193 focused mostly around getting something like this to work via the property assertion, but that discussion should be considered moot by the existing functionality already present in include that was simply overlooked.

Originally added in chaijs#230, asserting that an object contains a subset of
properties and values was never documented. Questions like chaijs#193 have
popped up asking for this feature even though it's been present since
1.9.0.

The discussion in chaijs#193 focused mostly around getting something like
this to work via the `property` assertion, but that discussion should
be considered moot by the existing functionality already present in
`include` that was simply overlooked.

Resolves: chaijs#193
keithamus added a commit that referenced this pull request Feb 8, 2016
Update include assertion docs for object properties
@keithamus keithamus merged commit 0ca50fe into chaijs:master Feb 8, 2016
@keithamus
Copy link
Member

👍

@wbyoung wbyoung deleted the update-include-docs branch February 8, 2016 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants