Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish npm packages with provenance #1615

Merged
merged 2 commits into from
May 10, 2024
Merged

Publish npm packages with provenance #1615

merged 2 commits into from
May 10, 2024

Conversation

koddsson
Copy link
Member

@koddsson koddsson commented May 9, 2024

This will allow us to have a cool badge on npm.

Example:
image

@koddsson koddsson marked this pull request as ready for review May 9, 2024 10:34
@koddsson koddsson requested a review from a team as a code owner May 9, 2024 10:34
- run: npm ci
- run: npm publish
- run: npm run build --if-present
- run: npm version ${TAG_NAME} --git-tag-version=false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean we can create releases without having to push a version bump to main?

Will we lose the tags and version in our package file by doing this? Sounds nice being able to release without the extra push but also I like having tags and the right version in the JSON 😅

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean we can create releases without having to push a version bump to main?

Yes.

Will we lose the tags and version in our package file by doing this? Sounds nice being able to release without the extra push but also I like having tags and the right version in the JSON 😅

Also yes. Typically I set package.json version to 0.0.0-development so it's clear that the version is generated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries I think that makes sense. @koddsson can you update the package version so that is clear?

keithamus
keithamus previously approved these changes May 9, 2024
Copy link
Member

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

43081j
43081j previously approved these changes May 9, 2024
@koddsson koddsson dismissed stale reviews from 43081j and keithamus via 8fac950 May 9, 2024 19:40
@koddsson koddsson enabled auto-merge (squash) May 9, 2024 19:40
@koddsson koddsson merged commit 5ab5b86 into main May 10, 2024
5 checks passed
@koddsson koddsson deleted the provenance branch May 10, 2024 08:29
koddsson pushed a commit to koddsson/chai that referenced this pull request Oct 6, 2024
* Publish npm packages with provenance

* Set version to 0.0.0 because we dynamically generate it now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants