Assertion always pass, no matter promise result

[endorama]

Hello, thanks for this library!

I'm stuck in trying to make chai-as-promised work. For some reason tests always pass or always fail, regardless promise result.

"promised" code:

function loadFile (filePath) {
    var deferred = Q.defer();
    deferred.reject(new Error('Some error'));
    return deferred.promise;
}

Test code:

it('should permit comments in project file', function() {
    return loadFile(projectFile).should.be.ok;
});

This test always pass, while is obvious that the promise is being rejected. What am I missing?
I read about issue #56 but this doesn't seem the case ( or is it?? ) as I'm rejecting with a proper Error.

If I change the code to use eventually:

it('should permit comments in project file', function() {
    return loadFile(projectFile).should.eventually.be.ok;
});

the test fails, but if I update the code to resolve the promise:

function loadFile (filePath) {
    var deferred = Q.defer();
    deferred.resolve('foobar');
    return deferred.promise;
}

the test now always fails...

Any help is appreciated :)

[domenic]

return loadFile(projectFile).should.be.ok;

You are not using Chai as Promised here at all. You are using just plain Chai. .should.be.ok tests if the object is truthy. All promises are objects, and so are automatically truthy.

return loadFile(projectFile).should.eventually.be.ok;

this should work. Can you produce a complete example file I can run, unmodified, in Mocha that demonstrates the problem?

[endorama]

You are not using Chai as Promised here at all. You are using just plain Chai. .should.be.ok tests if the object is truthy. All promises are objects, and so are automatically truthy.

This clarifies a lot the use of eventually ( I misunderstood the Readme ).

Cleaning up my code to create a valid example file I found the error that confused me in the beginning, and was a simple typo ( a P instead of p in one of the test cases, that obviously was always failing :( )

Thanks for the help! Everything is working great now. Closing

[domenic]

Awesome. If you can think of ways to clarify the readme, feel free to send a pull request.