Assertion does not fail if promise is rejected without reason

[tidlund]

In the following code, the two test cases should fail. However, they pass.

var chai = require('chai');
var chaiAsPromised = require('chai-as-promised');
chai.use(chaiAsPromised);
var assert = chai.assert;
var Q = require('q');

describe('Chai-test', function () {

  it('Should fail if rejected with no value ', function () {
    var promise = Q.reject();
    return assert.becomes(promise,2);
  });

  it('Should fail if rejected with no value (eventually.equal)', function () {
    var promise = Q.reject();
    return assert.eventually.equal(promise,2);
  });
});

[domenic]

Darn, I thought I fixed this.

While of course it is a bug in your code if you reject with a non-Error instance, this is indeed something Chai as Promised should catch. I'll try to track this down sometime during the next few weeks, but conferences will be keeping me busy, so pull request appreciated if you'd like it fixed sooner :)

[tidlund]

My mistake, the bug seems to be in Mochas testrunner. This yields the same result (without involvement of chai or chai-as-promised).:

it('Should fail if rejected with no value ', function () {
    return Q.reject();
});

Closing this issue.

[domenic]

Hmm right, yeah I think it is because Mocha bottoms out at the done style, and

it('should fail if called with an error that is undefined', function (done) {
  done(undefined);
});

counts as a success. In theory they should handle this better for promises.

---

That said, Chai as Promised should be able to handle this, as Chai as Promised doesn't communicate the original rejection directly to Mocha. Reopening for future fix.

[domenic]

I'm rolling up all bugs in the category "isRejected/rejectedWith doesn't behave like Chai's error rejectors" into #166.