Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Release 1.1.0 #12

Merged
merged 1 commit into from
Jan 3, 2018
Merged

Conversation

demurgos
Copy link
Contributor

@demurgos demurgos commented Jan 2, 2018

This commit bumps the version number (following #11 (comment)).

It is a semver minor update because type definitions are a feature in my opinion. Even if they don't change runtime, formalizing the documentation as types allows Typescript users to benefit from type checking.

cc @keithamus

- Add type definitions (chaijs#11)
@demurgos demurgos changed the title Release 1.1.0 chore: Release 1.1.0 Jan 2, 2018
Copy link
Member

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping @chaijs/assertion-error team for 1 more review.

Copy link
Member

@lucasfcosta lucasfcosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Let's get this merged! Thanks @demurgos 😄

Copy link
Member

@lucasfcosta lucasfcosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Let's get this merged! Thanks @demurgos 😄

@lucasfcosta lucasfcosta merged commit faa3f8c into chaijs:master Jan 3, 2018
@meeber
Copy link
Contributor

meeber commented Jan 3, 2018

@lucasfcosta I believe we need to create a Release on GitHub for this. Do you wanna do the honors?

@demurgos
Copy link
Contributor Author

demurgos commented Jan 5, 2018

Could you please send a message here so we get a notification once it's published? Thanks.

@keithamus
Copy link
Member

keithamus commented Jan 7, 2018

@demurgos this has been released ✌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants