Fixed typing and broadcasting issue for sequence types #2972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyballentine
approved these changes
Jul 1, 2024
joeyballentine
merged commit a1ce9d5
into
chaiNNer-org:generator-broadcasts
17 checks passed
joeyballentine
added a commit
that referenced
this pull request
Jul 15, 2024
* start of allowing generators to broadcast length data * allow output lengths to be set * Fixed typing and broadcasting issue for sequence types (#2972) * Fixed typing and broadcasting issue for sequence types * Fixed errors * Sequence item types for Load Video (#2974) * Sequence item types for Load Video * Ignore type error * Don't cache individually run generators and delete any caches on new run --------- Co-authored-by: Michael Schmidt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broadcasting now works properly. I also made it so that we broadcast a whole sequence type instead of the hacky solution with
'length'.I also improved the output types of Index in Load Images and Load Video, and I enabled broadcasting for Load Video.