Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Color type color not shading properly #2904

Merged
merged 1 commit into from
May 22, 2024
Merged

Conversation

joeyballentine
Copy link
Member

No description provided.

@RunDevelopment
Copy link
Member

The real problem is that we parse those hex colors incorrectly. See colorTools.ts -> hexToRgb. You could probably just use parseRgbHex from colorUtil to fix this.

Also, we could probably clean up or color utility...

@joeyballentine
Copy link
Member Author

Yeah probably, but this fixes the present issue. Redoing how this works can be a separate pr

@RunDevelopment
Copy link
Member

This PR isn't a fix but a workaround. Once the real bug is fixed, there's no point in making this change.

@joeyballentine
Copy link
Member Author

I don't really care about fixing the actual problem behind this right now. This works. Why not merge it?

@RunDevelopment
Copy link
Member

Because you're just accumulating tech debt, when the actual fix is pretty simple. Let me make a PR for it.

@RunDevelopment
Copy link
Member

Actually, let's go. I'm gonna just refactor our color stuff after this.

@RunDevelopment
Copy link
Member

Also, what issue was this even fixing? You never mentioned.

@joeyballentine
Copy link
Member Author

joeyballentine commented May 22, 2024

This was for color edges being invisible when you clicked on them

@joeyballentine joeyballentine merged commit 69a4b1e into main May 22, 2024
4 checks passed
@joeyballentine joeyballentine deleted the fix-color-styles branch May 22, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants