Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only trigger node doc search page open when doc page is open #2883

Merged
merged 1 commit into from
May 19, 2024
Merged

Only trigger node doc search page open when doc page is open #2883

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/renderer/components/NodeDocumentation/NodeDocumentationModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ const NodeDocumentationModal = memo(() => {

// select highest scoring schema
useEffect(() => {
if (searchScores && searchScores.size > 0) {
if (isOpen && searchScores && searchScores.size > 0) {
const highestScore = Math.max(...searchScores.values());
const highestScoreSchemaId = [...searchScores.entries()].find(
([, score]) => score === highestScore
Expand All @@ -109,7 +109,7 @@ const NodeDocumentationModal = memo(() => {
openNodeDocumentation(highestScoreSchemaId);
}
}
}, [searchScores, openNodeDocumentation]);
}, [isOpen, searchScores, openNodeDocumentation]);

return (
<Modal
Expand Down
Loading