Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename parameters of numeric inputs and clean up parameters #2863

Merged
merged 2 commits into from
May 18, 2024

Conversation

RunDevelopment
Copy link
Member

This PR renames the minimum, maximum, and control_step parameters of our numeric inputs to min, max, and step respectively.

I also used the shorter names to reformat a lot of inputs to be a single line. This makes a lot of nodes look a lot simpler.

Other changes:

  • Removed unnecessary parameters. E.g. I removed a lot of precision=0, because that's the default value.
  • Require kw arguments for some inputs. This just enforces what we're already doing everywhere.

@joeyballentine joeyballentine merged commit 9e8b538 into chaiNNer-org:main May 18, 2024
14 checks passed
@RunDevelopment RunDevelopment deleted the rn-number-parmas branch May 18, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants