Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for changing the type colors via themes.
One important thing i realized when doing this is that we definitely need to not define themes via sass. The amount of dependency lists i've had to add
theme
to, even though its not used anywhere inside the thing being memo'd, is ridiculous. And the worst part is, I can't do anything about a couple of them. For example, collapsed handles won't change until the node state changes due to how its rendered. Since the colors aren't actually being modified by anything react can see, it has no reason to rerender unless i force it to by misusing dep arrays. I'm pretty sure my theme object solution would take care of this. I'm also open to other solutions.Anyway, I only implemented different colors for the "ComfortUI" theme to sorta match their colors
It's more of a POC than anything else.