-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue #2734 fixed #2792
issue #2734 fixed #2792
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the work @RaySit!
Just one minor nit, and then this is good to go.
…into ray-contribution Merge remote changes to synchronize with ray-contribution branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @RaySit!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! (And thanks to your professor for having open source contribution as part of your final project 😄)
Changes to 'TabList' Component Behavior
Modification Overview:
This update modifies how tab changes are handled in the 'TabList' component to ensure that tab switching only occurs with left mouse clicks.
Key Changes:
onMouseDown
event. This function checks if the left mouse button ('event.button === 0') was clicked before changing the tab. This prevents unintended tab switches from right-clicks or middle-clicks.Screenshot demonstrating right-clicking a tab:
The user node menu is brought out as normal, but the tab is not switched.