Fix FLT_MAX ONNX -> NCNN error #2684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Converting this to a draft until i can figure out whats happening with the resulting NCNN models crashing the backend |
|
The model converts fine. The issue seems unrelated. Perhaps SPAN just can't be run in ncnn? |
|
@joeyballentine If you take a model converted to ONNX in new chaiNNer, and try to convert it to NCNN in an older version of chaiNNer this error happens no matter what arch it is. |
|
@Kim2091 that's unrelated. The float max error is due to the clipping introduced via spandrel with the call API. The crash I believe is arch dependent. This PR merely addresses the float max problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally looked into this bug. Basically, there's code that checks if a default value is a string and does some stuff if it is. Since FLT_MAX isn't a number and is instead a string, it was triggering the code to handle strings, when it really should be handled like a number. So, I just added a case to the if statement to ignore FLT_MAX and -FLT_MAX