Fix the hold-alt-to-intersect feature when using breakpoints #2586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mostly fixes using the alt-intersect feature when also using breakpoints. Now, it properly checks straight lines between breakpoints and half-curves for the other edges that are attached to breakpoints but also nodes.
The only issue is that it seems Bezier.js doesn't take curvature into account the same way an SVG does, so the "sticking out" part of a curve won't get collision detected, since the curve along that point (close to the handle) is different in bezier.js. I don't think this is something we can fix unless we fork bezierjs or write our own bezier code.