Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more inputs/outputs to Pass Through #2549

Merged
merged 6 commits into from
Feb 7, 2024
Merged

Add more inputs/outputs to Pass Through #2549

merged 6 commits into from
Feb 7, 2024

Conversation

joeyballentine
Copy link
Member

@joeyballentine joeyballentine commented Feb 5, 2024

Suggested by @mrjschulte

image

@joeyballentine joeyballentine changed the title Add a "Hub" node Add more inputs/outputs to passthrough Feb 5, 2024
@joeyballentine joeyballentine changed the title Add more inputs/outputs to passthrough Add more inputs/outputs to Pass Through Feb 5, 2024
@RunDevelopment
Copy link
Member

What's the motivation for this?

@joeyballentine
Copy link
Member Author

What's the motivation for this?

https://discord.com/channels/930865462852591648/934155622490984520/1203929089941962812

I guess it saves you needing to have multiple passthrough nodes. I'm not too sure of the usefulness myself but since it wasn't too difficult to add I don't see a reason to not do it

@mrjschulte
Copy link
Contributor

Sometimes you want to be able to design a node flow that doesn't have to source all of its originating connections from the other end of the schematic. A Passthrough/Hub such as this is a great addition to the layout and flow of the processes and helps the User visually "lay out" where things need to go. Thanks for the work here @joeyballentine !

@RunDevelopment
Copy link
Member

I just noticed that this node will interfere with our dead node elimination optimization. Since that optimization doesn't know which inputs are actually used, it can't remove unused ones. So we'll have to add another optimization to do that for us. That can be its own PR though.

@joeyballentine joeyballentine merged commit 2e69bd3 into main Feb 7, 2024
14 checks passed
@joeyballentine joeyballentine deleted the hub-node branch February 7, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants