Update load_video node for more accurate color conversion and chroma reconstruction #2532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…construction This PR updates the ffmpeg based load_video node to use a more accurate color decoding and chroma reconstruction path. This node now uses lanczos filtering by default and also skips the previously present extra conversion from rgb24 to bgr24 by having ffmpeg send a bgr24 rawvideo pipe natively to chaiNNer
joeyballentine
previously approved these changes
Jan 29, 2024
|
We use a great package called |
remove cv2 import as this is no longer needed.
|
Ok, removed the dead cv2 import so should be good now. |
joeyballentine
approved these changes
Jan 29, 2024
|
question: sws flags are for scaling, why having added them? |
Chroma is typically stored at a low resolution, so it needs to be upsampled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the ffmpeg based load_video node to use a more accurate color decoding and chroma reconstruction path.
This node now uses lanczos filtering by default and also skips the previously present extra conversion from rgb24 to bgr24 by having ffmpeg send a bgr24 rawvideo pipe natively to chaiNNer