-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resizable Image Previews #2167
Resizable Image Previews #2167
Conversation
This is a big issue, because it will noticeably degrade performance on non-high-end devices. Why did you remove that anyway? |
Because the size of the image itself is now more than just a display thing. If you make the node full res and the UI switches it to the smaller image, it'll shrink the image being displayed. I'm not sure how to get around that besides always stretching the image to the bounds of the node, which I'm not sure could be made to retain aspect ratio. I'm open to suggestions |
I did figure out how to get around that btw. It works pretty well now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. Just a few questions.
Found some bugs:
|
I don't think this is something I can really fix. There's actually a bunch of issues with snap to grid all around chaiNNer, like iterator child nodes popping out of the iterator container. IMO this is a non-issue and the real issue is we need to better support snap to grid somehow |
Self explanatory. Closes #782
Decisions I had to make: