SD Check status code #1648
Merged
SD Check status code #1648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webui returns a 404 JSON message when --api isn't passed. I think it used to return invalid JSON, but now it doesn't fail correctly so we need to check the status code
RunDevelopment
approved these changes
Mar 12, 2023
|
Does this check still work for older versions of the webui? |
That is an excellent question. I will check and get back to you |
|
Any update on this? |
|
I'm going to merge this so the nightlies will work with the latest webui |
|
Sorry about the delay. I tested against today's version of webui and the one from the beginning of the month, and they both seem to have the correct behavior with the current patch. Auto1111: a9fed7c364061ae6efb37f797b6b522cb3cf7aa2 (latest, March 14)
Auto1111: b14d8b61bdc4cc2e6c0ea484a5ba8fd370231227 (March 1)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
webui returns a 404 JSON message when --api isn't passed. I think it used to return invalid JSON, but now it doesn't , so it doesn't fail correctly, so we need to check the status code.
Also if webui gives us an error code, put the error message in our logs.