Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(hotifx) Seed types should be cacheable #1623

Merged
merged 1 commit into from
Mar 3, 2023
Merged

(hotifx) Seed types should be cacheable #1623

merged 1 commit into from
Mar 3, 2023

Conversation

adodge
Copy link
Contributor

@adodge adodge commented Mar 3, 2023

currently all SD nodes are broken, since they use the SeedInput and also the @cached decorator

@adodge adodge marked this pull request as ready for review March 3, 2023 20:04
@joeyballentine joeyballentine merged commit e6c7f0b into chaiNNer-org:main Mar 3, 2023
@adodge
Copy link
Contributor Author

adodge commented Mar 3, 2023 •
edited
Loading

in retrospect I should have just used __hash__ instead of a new function name

@joeyballentine
Copy link
Member

@adodge feel free to make another PR but if this works I'm fine with it. Will release later today

@adodge
Copy link
Contributor Author

adodge commented Mar 3, 2023 •
edited
Loading

we can change it later. this is good for a hotfix, since it's probably not going to break anything else. Adding a __hash__ to the Seed type might theoretically affect something somewhere else

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeyballentine joeyballentine joeyballentine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adodge @joeyballentine