Add Convert Number to base-10 node #1621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RunDevelopment
requested changes
Mar 4, 2023
|
Thank you for the review. I appreciate the explanations too. It's been a while for python for me |
|
I wonder whether we should call the node "Parse Number" instead. "Convert" is quite generic. Thoughts? |
|
I also prefer a more technical name like parse but when i was workshopping it in discord there was a general reticence towards programmer jargon even if they're more correct. I like Parse Number a lot more than convert. Makes it easier to quick search for too. |
|
Maybe "extract number"? |
|
"Extract" feels more like a substring manipulation. It'd feel even weirder imo if/ when there's actual string extraction. Parse is still my vote on verb. It's unambiguous and doesn't overlap with other nodes. |
Reviewed by: Michael Schmidt <[email protected]>
Co-authored-by: Michael Schmidt <[email protected]>
RunDevelopment
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small node to go from any text to a base-10 integer.
Criticism and/ or improvements welcome.