Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add way to view external connections #1559

Merged
merged 2 commits into from
Feb 14, 2023
Merged

Add way to view external connections #1559

merged 2 commits into from
Feb 14, 2023

Conversation

joeyballentine
Copy link
Member

@joeyballentine joeyballentine commented Feb 14, 2023 •
edited
Loading

Somewhat temporary solution

image
image

RunDevelopment
RunDevelopment requested changes Feb 14, 2023
View reviewed changes
Copy link
Member

@RunDevelopment RunDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Man, we really need that backend refactor so the backend can declare and check its own dependencies.

I don't like this, but I don't think that there is a better way to do it rn.

src/common/externalIntegrations.ts Show resolved Hide resolved
src/renderer/contexts/DependencyContext.tsx Outdated Show resolved Hide resolved
RunDevelopment
RunDevelopment approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@RunDevelopment RunDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still don't like process.env, but that problem will solve itself when we finally let the backend declare its own dependencies.

@joeyballentine
Copy link
Member Author

yeah its just a temporary solution

@joeyballentine joeyballentine merged commit f932962 into main Feb 14, 2023
@joeyballentine joeyballentine deleted the external-connection-viewer branch February 14, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RunDevelopment RunDevelopment RunDevelopment approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joeyballentine @RunDevelopment