Skip to content

Commit

Permalink
main: Move "rpm-ostree container" → "rpm-ostree ex container"
Browse files Browse the repository at this point in the history
Now all of our "experimental" bits are under one roof, so we get consistent
handling for them.

Closes: coreos#683
Approved by: jlebon
  • Loading branch information
cgwalters authored and rh-atomic-bot committed Mar 16, 2017
1 parent 8dfed46 commit 710ea30
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 8 deletions.
2 changes: 0 additions & 2 deletions src/app/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,6 @@ static RpmOstreeCommand commands[] = {
/* Experimental */
{ "ex", RPM_OSTREE_BUILTIN_FLAG_LOCAL_CMD | RPM_OSTREE_BUILTIN_FLAG_EXPERIMENTAL,
rpmostree_builtin_ex },
{ "container", RPM_OSTREE_BUILTIN_FLAG_LOCAL_CMD | RPM_OSTREE_BUILTIN_FLAG_EXPERIMENTAL,
rpmostree_builtin_container },
/* Hidden */
{ "start-daemon", RPM_OSTREE_BUILTIN_FLAG_LOCAL_CMD | RPM_OSTREE_BUILTIN_FLAG_REQUIRES_ROOT |
RPM_OSTREE_BUILTIN_FLAG_HIDDEN,
Expand Down
3 changes: 3 additions & 0 deletions src/app/rpmostree-builtin-ex.c
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,14 @@
#include "config.h"

#include "rpmostree-ex-builtins.h"
#include "rpmostree-container-builtins.h"
#include "rpmostree-rpm-util.h"

static RpmOstreeCommand ex_subcommands[] = {
{ "unpack", RPM_OSTREE_BUILTIN_FLAG_LOCAL_CMD,
rpmostree_ex_builtin_unpack },
{ "container", RPM_OSTREE_BUILTIN_FLAG_LOCAL_CMD,
rpmostree_builtin_container },
{ NULL, 0, NULL }
};

Expand Down
12 changes: 6 additions & 6 deletions tests/check/test-ucontainer.sh
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ set -euo pipefail

echo "1..2"

rpm-ostree container init
rpm-ostree ex container init

cp ${commondir}/compose/test-repo.repo rpmmd.repos.d

Expand All @@ -34,7 +34,7 @@ packages=empty
repos=test-repo
EOF

rpm-ostree container assemble empty.conf
rpm-ostree ex container assemble empty.conf
assert_has_dir roots/empty.0
ostree --repo=repo rev-parse empty
echo "ok assemble"
Expand All @@ -44,7 +44,7 @@ cat >nobranch.conf <<EOF
packages=empty
repos=test-repo
EOF
if rpm-ostree container assemble nobranch.conf 2>err.txt; then
if rpm-ostree ex container assemble nobranch.conf 2>err.txt; then
assert_not_reached "nobranch.conf"
fi

Expand All @@ -54,7 +54,7 @@ ref=empty
packages=
repos=test-repo
EOF
if rpm-ostree container assemble nopackages.conf 2>err.txt; then
if rpm-ostree ex container assemble nopackages.conf 2>err.txt; then
assert_not_reached "nopackages.conf"
fi

Expand All @@ -63,7 +63,7 @@ cat >norepos.conf <<EOF
ref=empty
packages=empty
EOF
if rpm-ostree container assemble norepos.conf 2>err.txt; then
if rpm-ostree ex container assemble norepos.conf 2>err.txt; then
assert_not_reached "norepos.conf"
fi

Expand All @@ -73,7 +73,7 @@ ref=notfound
packages=notfound
repos=test-repo
EOF
if rpm-ostree container assemble notfound.conf 2>err.txt; then
if rpm-ostree ex container assemble notfound.conf 2>err.txt; then
assert_not_reached "notfound.conf"
fi

Expand Down

0 comments on commit 710ea30

Please sign in to comment.