[merged] Fix error handling during iteration, better submodule error message #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First, we need to cleanly break iteration if we caught an error. Fix our return code checks to use `!= 0`, and break the iterator as early as possible if we flagged an error. Second, if we fail to open a submodule, give the user a hint. Closes #16
cgwalters-bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, we need to cleanly break iteration if we caught an error. Fix
our return code checks to use
!= 0, and break the iterator as earlyas possible if we flagged an error.
Second, if we fail to open a submodule, give the user a hint.
Closes #16