fix: remove duplicate srcs when evaluating clang files #1452
Conversation
karim-alweheshy
requested review from
brentleyjones,
cgrindel,
jpsim and
luispadron
as code owners
| @@ -250,7 +250,7 @@ def _collect_files( | |||
|
|
|||
| modulemap = None | |||
| modulemap_orig_path = None | |||
| for orig_path in all_srcs: | |||
| for orig_path in depset(all_srcs).to_list(): | |||
There was a problem hiding this comment.
Can you elaborate how we are getting duplicate sources in the first place?
There was a problem hiding this comment.
in Package.swift we have publicHeadersPath: ".", which then extends the lookup into . and into ./yoga both of which generate a duplicated module.modulemap src
There was a problem hiding this comment.
This needs to be merged first and then I'll update this PR
There was a problem hiding this comment.
Will you even need this PR, once the other PR merges?
There was a problem hiding this comment.
yes the other PR fixes something different related to picking up public headers unrelated to the compiled target
cgrindel
changed the title
There was a problem hiding this comment.
Thank you for adding the example. To fully integrate the example with the repo, you will need to add the example to this list. Then, you will need to run bazel run //:tidy. This will update some source files that will need to be added to this PR.
This resolves a case for using https://github.com/facebook/yoga from https://github.com/layoutBox/FlexLayout