Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if popup close event is relevant #160

Closed
chris-steele opened this issue Jan 17, 2025 · 1 comment · Fixed by #161
Closed

Check if popup close event is relevant #160

chris-steele opened this issue Jan 17, 2025 · 1 comment · Fixed by #161
Assignees
@chris-steele
Labels
enhancement released

Comments

@chris-steele
Copy link
Contributor

chris-steele commented Jan 17, 2025 •
edited
Loading

With plugins such as adapt-definitions, additional popups may overlay the one opened by this plugin, therefore a check of which popup is being closed should be made.

N.B. this change should be made for similar components such as hotgraphic etc.
@chris-steele chris-steele self-assigned this Jan 17, 2025
@chris-steele chris-steele mentioned this issue Jan 17, 2025
Merged
@swashbuck swashbuck linked a pull request Jan 17, 2025 that will close this issue
Fix: check if popup close event is relevant (fixes #160) #161
Merged
oliverfoster pushed a commit that referenced this issue Jan 27, 2025
@chris-steele
Fix: check if popup close event is relevant (fixes #160) (#161)
676f12c
github-actions bot pushed a commit that referenced this issue Jan 27, 2025
@semantic-release-bot
Chore(release): 4.6.4 [skip ci]
1ddd416 
## [4.6.4](v4.6.3...v4.6.4) (2025-01-27)

### Fix

* check if popup close event is relevant (fixes #160) (#161) ([676f12c](676f12c)), closes [#160](#160) [#161](#161)
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 4.6.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chris-steele chris-steele

Labels
enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: check if popup close event is relevant (fixes #160) cgkineo/adapt-hotgrid
2 participants
@swashbuck @chris-steele