[Unified] Waypoints of stored Labs are not made visible visible until lab cache is tapped, "visited" waypoints are not filtered out

[eddiemuc]

c:geo-Version: 2024.12.17-RC

Tested with Lab "Zwischen Einkaufstempel und Architektur" in Hamburg near N 53° 33.053' E 009° 59.636'.
This problem might also occur with other cache types, I haven't tested this.
Problems happens on Unified Mapsforge, VTM and Google.

Precondition:

• unified map is selected
• map position is currently placed somewhere such that an offline-stored Lab Cache and it's waypoints are inside the viewport.
• Some of the waypoints are marked as "visited", some are not
• map is not currently opened (eg we might be in "stored list" section)

Error reproduction:

• Open the map --> Lab is shown (ok) but not its waypoints (Error):
  

• open the popup for the lab cache:
  

• close popup again --> waypoints of lab are now shown...
  

• ...but already visited waypoints are ALSO shown allthough they should be filtered out:

[eddiemuc]

@moving-bits I debugged into this and found that when initially opening the map, the only place where waypoints are loaded is the method UnifiedMapActivity.loadWaypoints(). This method however is called only once with an illegal (just-a-dot) viewport, resulting in zero waypoints being loaded.

I am not sure how the cache/waypoint loading/filtering architecture of unified map is supposed to behave here.

[eddiemuc]

Can't extract the systematics of this out of the code. If I would need to tackle this then I would need to redesign a lot.

[bekuno]

Maybe the same reason as in #16461?

[eddiemuc]

Maybe the same reason as in #16461?

There seem to be some things intertweened here. I will take a look at #16461 too.

While testing around I noticed that each change on a cache (eg marking a waypoint as visited) causes a retriggering of the online search in live mode. This is not ideal

[moving-bits]

@moving-bits I debugged into this and found that when initially opening the map, the only place where waypoints are loaded is the method UnifiedMapActivity.loadWaypoints(). This method however is called only once with an illegal (just-a-dot) viewport, resulting in zero waypoints being loaded.

I am not sure how the cache/waypoint loading/filtering architecture of unified map is supposed to behave here.

loadWaypoints() should be called in LoadInBackgroundHandler on every cycle, with the then-valid viewport.

The other two calls in reloadCachesAndWaypoints() are added to make sure waypoints are being shown independent from current viewport in case of list or searchresult.

But there haven quite a few changes over time, and there will (still) be bugs in the code for sure, so if you plan to make adjustments or even to refactor, please go ahead.

[eddiemuc]

PR #16484 changes the logic so much that this issue doesn't make much sense any more, thus closing here.