Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_page_async() relies on NPM request, which is deprecated #92

Open
casselldev opened this issue Dec 5, 2022 · 2 comments
Open

get_page_async() relies on NPM request, which is deprecated #92

casselldev opened this issue Dec 5, 2022 · 2 comments

Comments

@casselldev
Copy link

It is eventually going to be problematic that DDE's get_page_async() function relies on the NPM request package, which was deprecated in 2020 (see here: https://www.npmjs.com/package/request)

Although it mostly still functions, it is worth replacing request with a newer package like fetch or axios to prevent a breaking change down the line.

@cfry
Copy link
Owner

cfry commented Dec 6, 2022

fetch
is defined in DDE4 both IDE and Job Engine.

@cfry
Copy link
Owner

cfry commented Dec 6, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants