6 bugs fixed for release

HCA/ipg_to_json.js

@@ -25,11 +25,13 @@ Implement: do capture that 2nd line, perhaps as:
 
 */
 
-var ipg_to_json = class ipg_to_json{
-    static parse(ipg){
-        if((ipg.length < 256) && ipg.endsWith(".ipg")){
-            ipg = read_file(ipg)
+globalThis.ipg_to_json = class ipg_to_json{
+    //ipg can be either a file name or a big string of ipg
+    static async parse(ipg) {
+        if ((ipg.length < 256) && ipg.endsWith(".ipg")) {
+            ipg = await DDEReadFile.read_file(ipg)
         }
+
         ipg = replace_substrings(ipg, "\\\\", "/", false)
         ipg = replace_substrings(ipg, "\\", "/", false)
         ipg = replace_substrings(ipg, "\u0001", " ", false)

core/dextersim.js

@@ -377,7 +377,7 @@ DexterSim = class DexterSim{
            //unfortunately g0 doesn't support J6_SENT or J7_SENT
         }
 
-        if(this.status_mode === 1){
+        else if(this.status_mode === 1){
             //needs work
         }
 

core/index.js

@@ -1,5 +1,5 @@
-global.dde_version = "3.8.8" //require("../package.json").version
-global.dde_release_date = "Jul 26, 2022" //require("../package.json").release_date
+global.dde_version = "3.8.9" //require("../package.json").version
+global.dde_release_date = "Sep 30, 2022" //require("../package.json").release_date
 
 console.log("dde_version: " + global.dde_version + " dde_release_date: " + global.dde_release_date +
             "\nRead electron_dde/core/job_engine_doc.txt for how to use the Job Engine.\n")
@@ -158,7 +158,7 @@ var calibrate_build_tables = require("../low_level_dexter/calibrate_build_tables
 var DXF    = require("../math/DXF.js")
 var {init_units} = require("./units.js")
 var {FPGA} = require("./fpga.js")
-require('./core/dexter_defaults.js')
+require('./dexter_defaults.js') //bug: needed to  take out /core from the path
 
 var {convertArrayBufferToString, convertStringToArrayBuffer,
      SerialPort, serial_connect, serial_connect_low_level,

core/storage.js

@@ -20,8 +20,8 @@ function get_persistent_values_defaults() {
 
             "dde_window_x":       50,
             "dde_window_y":       50,
-            "dde_window_width":  outerWidth,
-            "dde_window_height":  outerHeight,
+            "dde_window_width":   1024, //outerWidth, bug fix
+            "dde_window_height":  720,  //outerHeight, bug fix
             "left_panel_width":   700,
             "top_left_panel_height": 350,
             "top_right_panel_height": 200,

doc/guide.html

@@ -9,7 +9,7 @@
 <details class="doc_details"><summary>About</summary>
     This is <a href="http://hdrobotic.com/" target="_blank">Dexter</a> Development Environment<br/>
     version: <span id="dde_version_id">3.8.8</span><br/>
-    released: <span id="dde_release_date_id">Jul 26, 2022</span>
+    released: <span id="dde_release_date_id">Sep 30, 2022</span>
     <p></p>
     DDE helps you create, debug, and send software to a Dexter robot.
     You can use any JavaScript augmented with DDE-specific functions to help find out about,

doc/known_issues.html

@@ -10,15 +10,15 @@
 with this DDE release. All of them are on our "do list".
 <p></p>
 <ul>
-  <li>Defaults.make_ins processing in DDE is brand new and may have some bugs in it.</li>
+  <li>Defaults.make_ins processing in DDE is new and may have some bugs in it.</li>
   <li>Sometimes, on Windows 10 computers, the editor pane won't accept typed in characters.
       Workaround: Shrink and expand the DDE window or click outside the DDE window
       then click back in it.</li>
   <li> <code>Plot.show(...)</code> shows a bunch of icons in the upper right of a plot window.
        Most of these don't work (at least well).</li>
-   <li> The simulator <b>both</b> setting basically works but real and sim are not in
+  <li> The simulator <b>both</b> setting basically works but real and sim are not in
        perfect sync.</li>
-   <li> The simulator does not work for DELTA, PID_DELTA, A2D_SIN, A2D_COS.</li>
+  <li> The simulator does not work for DELTA, PID_DELTA, A2D_SIN, A2D_COS.</li>
   <li>The Messaging software is not yet intended for public use. We're still testing.</li>
   <li>Jobs menu/Run Jobs on Dexter will take some work to get it to operate smoothly.
       You'll also need a new SD card image on your Dexter.</li>

doc/release_notes.html

@@ -6,6 +6,20 @@
     .doc_details summary { font-weight: 600; }
 </style>
 
+<details class="doc_details"><summary>v 3.8.9, Sep 30, 2022</summary>
+Highlights: Bug fixes.
+<ul>
+    <li>Fixed bug in Simulator whereby if you redefined a Dexter that was previously
+        simulated in the current DDE session, that redefinition wasn't reflexed in the simulator,
+        causing problems.</li>
+    <li>robot_status.js now properly usesDexter.J1_MEASURED_ANGLE_G1 instead of 10.
+        This does not change functionality.</li>
+    <li>Inspector: 4 "extra info" infinite loop bugs fixed.</li>>
+    <li>Fixed bug in core/index.js for the folder of the require statement that loads dexter_defaults.js</li>
+    <li>Fixed bug in storage.js of the default value for outerWidth and outerHeight.</li>
+</ul>
+</details>
+
 <details class="doc_details"><summary>v 3.8.8, Jul 26, 2022</summary>
     Highlights: Fixes and robustification of parsing the Defaults.make_ins file.
     New Instruction: Dexter.reboot_robot.

inspect.js

@@ -586,11 +586,22 @@ function inspect_extra_info(item){
     else if (window.Ammo && (item === Ammo)) { //because JSON.stringify(Ammo) causes infinite recursion
         info = "Ammo"
     }
+    else if (item.hasOwnProperty("default_workspace_pose") ||
+             item.hasOwnProperty("L0") ||
+             item.hasOwnProperty("L1") ||
+             item.hasOwnProperty("L2") ||
+             item.hasOwnProperty("L3") ||
+             item.hasOwnProperty("L4") ||
+             item.hasOwnProperty("L5")){ //the value of this field is a
+        //JSON.stringify circular structure and causes an error
+        info = //"has default_workspace_pose which is a circular structure, causing error."
+              "click blue underlined text to inspect"
+    }
     else {
         //console.log("non-array extra info: ") // + item)
         //info = "extra info cannot inspect"
         //causes infinit loop when inspecting window, but it must be some field within window, not window itself
-        try{ info = JSON.stringify(item) } //JSON.stringify(Ammo) causes infinit loop so I must catch this above.
+        try{ info = JSON.stringify(item) } //JSON.stringify(Ammo) causes infinite loop so I must catch this above.
         catch(err) { return "" }
     }
     if (info.length > 55) {

package.json

@@ -1,8 +1,8 @@
 {
   "name": "dexter_dev_env",
   "productName": "dexter_dev_env",
-  "version": "3.8.8",
-  "release_date": "Jul 26 2022",
+  "version": "3.8.9",
+  "release_date": "Sep 30, 2022",
   "description": "Dexter Development Environment for programming the Dexter robot.",
   "author": "Fry",
   "license": "GPL-3.0",