Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor hmda analytics #4959

Merged
merged 8 commits into from
Jan 28, 2025

Conversation

aharjatiRaft
Copy link

@aharjatiRaft aharjatiRaft commented Jan 15, 2025

refactor hmda analytics.

Closes #4961

tested on dev:

  • Upload multiple submission file with different length and verified that postgres is updated with these different rows

tested locally:

hmda-platform

[info] Run completed in 3 minutes, 55 seconds.
[info] Total number of tests run: 549
[info] Suites: completed 393, aborted 0
[info] Tests: succeeded 549, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.
[success] Total time: 254 s (04:14), completed Jan 21, 2025, 12:33:24 PM

common-tests

[info] Run completed in 10 seconds, 105 milliseconds.
[info] Total number of tests run: 178
[info] Suites: completed 45, aborted 0
[info] Tests: succeeded 178, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.
[success] Total time: 15 s, completed Jan 21, 2025, 12:52:25 PM


check-digit

[info] Run completed in 5 seconds, 256 milliseconds.
[info] Total number of tests run: 10
[info] Suites: completed 2, aborted 0
[info] Tests: succeeded 10, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.
[success] Total time: 30 s, completed Jan 21, 2025, 12:54:09 PM


data-browser

[info] Run completed in 11 seconds, 176 milliseconds.
[info] Total number of tests run: 35
[info] Suites: completed 4, aborted 0
[info] Tests: succeeded 35, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.
[success] Total time: 32 s, completed Jan 21, 2025, 12:55:46 PM

hmda-analytics

[info] Run completed in 10 seconds, 814 milliseconds.
[info] Total number of tests run: 12
[info] Suites: completed 4, aborted 0
[info] Tests: succeeded 12, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.
[success] Total time: 17 s, completed Jan 21, 2025, 12:57:36 PM

data-publisher

[info] Run completed in 24 seconds, 190 milliseconds.
[info] Total number of tests run: 55
[info] Suites: completed 25, aborted 0
[info] Tests: succeeded 55, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.
[success] Total time: 76 s (01:16), completed Jan 21, 2025, 12:59:41 PM

hmda_quarterly_data_service_tests

[info] Run completed in 4 seconds, 402 milliseconds.
[info] Total number of tests run: 80
[info] Suites: completed 40, aborted 0
[info] Tests: succeeded 80, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.
[success] Total time: 24 s, completed Jan 21, 2025, 1:00:36 PM

hmda_reporting_tests

Run completed in 10 seconds, 517 milliseconds.
[info] Total number of tests run: 3
[info] Suites: completed 2, aborted 0
[info] Tests: succeeded 3, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.
[success] Total time: 30 s, completed Jan 21, 2025, 1:01:51 PM

institutions_api_tests

[info] Run completed in 9 seconds, 294 milliseconds.
[info] Total number of tests run: 20
[info] Suites: completed 7, aborted 0
[info] Tests: succeeded 20, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.
[success] Total time: 42 s, completed Jan 21, 2025, 1:04:40 PM

modified_lar_tests

[info] Run completed in 4 seconds, 470 milliseconds.
[info] Total number of tests run: 5
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 5, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.
[success] Total time: 19 s, completed Jan 21, 2025, 1:05:53 PM

rate_limit_tests

[info] Run completed in 2 seconds, 807 milliseconds.
[info] Total number of tests run: 1
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 1, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.
[success] Total time: 16 s, completed Jan 21, 2025, 1:07:57 PM

ratespread_calculator_tests

[info] Run completed in 4 seconds, 979 milliseconds.
[info] Total number of tests run: 6
[info] Suites: completed 3, aborted 0
[info] Tests: succeeded 6, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.
[success] Total time: 23 s, completed Jan 21, 2025, 1:12:27 PM

submission_errors_tests

[info] Run completed in 7 seconds, 858 milliseconds.
[info] Total number of tests run: 2
[info] Suites: completed 2, aborted 0
[info] Tests: succeeded 2, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.
[success] Total time: 20 s, completed Jan 21, 2025, 1:14:41 PM

@PatrickGoRaft PatrickGoRaft changed the base branch from master to post-filing-2025 January 21, 2025 09:53
Add SBT to cve-scan workflow
Copy link
Contributor

@tptignor tptignor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tptignor
Copy link
Contributor

PR still looks good, but it seems like the unit tests are broken:

/home/runner/work/_temp/b440ea37-cb16-4b37-92e6-3664656b552c.sh: line 1: sbt: command not found

@PatrickGoRaft
Copy link
Contributor

LGTM

@PatrickGoRaft PatrickGoRaft merged commit 39838c7 into cfpb:post-filing-2025 Jan 28, 2025
1 of 3 checks passed
@aharjatiRaft aharjatiRaft deleted the analytics_refactor branch January 28, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants