-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Email Microservice #3095
Email Microservice #3095
Conversation
…ka). The record will be of kind: <submission-id>:<email>
Codecov Report
@@ Coverage Diff @@
## master #3095 +/- ##
==========================================
- Coverage 51.26% 50.24% -1.02%
==========================================
Files 577 577
Lines 12458 11818 -640
Branches 294 298 +4
==========================================
- Hits 6386 5938 -448
+ Misses 6072 5880 -192
Continue to review full report at Codecov.
|
…<submissionId>:<email>
* change topic name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -58,8 +58,12 @@ hmda { | |||
disclosureTopic = ${?KAFKA_DISCLOSURE_TOPIC} | |||
adTopic = "hmda-spark-ad" | |||
adTopic = ${?KAFKA_AD_TOPIC} | |||
emailTopic = "hmda-email" | |||
emailTopic = ${?KAFKA_AD_TOPIC} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
KAFKA_EMAIL_TOPIC
?
Closes #3059
POST
endpoint for Sign to includeemail
field