Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email Microservice #3095

Merged
merged 23 commits into from
Oct 8, 2019
Merged

Email Microservice #3095

merged 23 commits into from
Oct 8, 2019

Conversation

omnipresent07
Copy link
Contributor

@omnipresent07 omnipresent07 commented Sep 16, 2019

Closes #3059

  • Enhance POST endpoint for Sign to include email field
  • Add record to kafka topic for emails at time of signins
  • Build email microservice to read the kafka topic
  • Send the email via SES and commit to kafka topic

@omnipresent07 omnipresent07 changed the title Email Microservice WIP: Email Microservice Sep 16, 2019
@codecov
Copy link

codecov bot commented Sep 20, 2019

Codecov Report

Merging #3095 into master will decrease coverage by 1.01%.
The diff coverage is 70.4%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3095      +/-   ##
==========================================
- Coverage   51.26%   50.24%   -1.02%     
==========================================
  Files         577      577              
  Lines       12458    11818     -640     
  Branches      294      298       +4     
==========================================
- Hits         6386     5938     -448     
+ Misses       6072     5880     -192
Impacted Files Coverage Δ
common/src/main/scala/hmda/api/HmdaServer.scala 0% <ø> (ø) ⬆️
...cala/hmda/query/ts/TransmittalSheetConverter.scala 100% <ø> (ø) ⬆️
...in/scala/hmda/validation/rules/IfTsPresentIn.scala 100% <ø> (ø) ⬆️
...ssages/submission/SubmissionProcessingEvents.scala 0% <ø> (ø) ⬆️
.../main/scala/hmda/parser/filing/lar/LarParser.scala 82.05% <ø> (ø) ⬆️
.../main/scala/hmda/publication/HmdaPublication.scala 0% <ø> (ø) ⬆️
...ala/hmda/util/conversion/ColumnDataFormatter.scala 0% <ø> (ø) ⬆️
...main/scala/hmda/validation/dsl/PredicateHmda.scala 88.88% <ø> (ø) ⬆️
...mda/persistence/institution/InstitutionState.scala 75% <ø> (ø) ⬆️
...la/hmda/validation/engine/2019/LarEngine2019.scala 100% <ø> (ø) ⬆️
... and 372 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c40db4b...f179a06. Read the comment docs.

@omnipresent07 omnipresent07 changed the title WIP: Email Microservice Email Microservice Sep 24, 2019
Copy link
Contributor

@PatrickGoRaft PatrickGoRaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -58,8 +58,12 @@ hmda {
disclosureTopic = ${?KAFKA_DISCLOSURE_TOPIC}
adTopic = "hmda-spark-ad"
adTopic = ${?KAFKA_AD_TOPIC}
emailTopic = "hmda-email"
emailTopic = ${?KAFKA_AD_TOPIC}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KAFKA_EMAIL_TOPIC?

@PatrickGoRaft PatrickGoRaft merged commit ee7e7c0 into cfpb:master Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement email confirmation post submission
2 participants