Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Django 3.2 #79

Merged
merged 1 commit into from
Apr 6, 2021
Merged

Add support for Django 3.2 #79

merged 1 commit into from
Apr 6, 2021

Conversation

dduong42
Copy link
Contributor

@dduong42 dduong42 commented Apr 6, 2021

No description provided.

@willbarton
Copy link
Member

willbarton commented Apr 6, 2021

The coverage submission error is a repository configuration error. Fixing that now.

EDIT: Actually, I'm not so sure. Looking further into it.

Copy link
Member

@willbarton willbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Django 3.2 is an LTS release, I'd be okay dropping 3.0 and 3.1 from our test matrix. I've added suggestions to do that. You're welcome to accept them, or we can do it in another PR before we release.

.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
@willbarton
Copy link
Member

This looks good, thank you!

I'll fix coverage submission in a separate PR and then get this released!

@willbarton willbarton merged commit a074ed2 into cfpb:main Apr 6, 2021
@dduong42 dduong42 deleted the django-3.2 branch April 6, 2021 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants