Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DATAP-1570 various styling fixes #560

Merged
merged 9 commits into from
Nov 26, 2024
Merged

DATAP-1570 various styling fixes #560

merged 9 commits into from
Nov 26, 2024

Conversation

cdmh219
Copy link
Collaborator

@cdmh219 cdmh219 commented Nov 25, 2024

Made fixes to update the margins on the error and warning notifications

Additions

Removals

Changes

Testing

Screenshots

Screenshot 2024-11-25 at 2 21 09 PM Screenshot 2024-11-25 at 2 25 46 PM

Notes

Todos

Checklist

  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the front end playbook
  • Passes all existing automated tests
  • New functions include new tests
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged
  • Visually tested in supported browsers and devices
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

Copy link
Contributor

@flacoman91 flacoman91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but i am still seeing issues with the labels above the buttons. I'll add the info in the jira ticket

@flacoman91 flacoman91 added this pull request to the merge queue Nov 26, 2024
Merged via the queue into main with commit ec0943c Nov 26, 2024
2 checks passed
@flacoman91 flacoman91 deleted the DATAP-1570-Styling-Fixes branch November 26, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants