Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to prod data during local development #486

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Default to prod data during local development #486

merged 2 commits into from
Jan 24, 2024

Conversation

contolini
Copy link
Member

Changes the local dev environment to use the production complaints API at consumerfinance.gov by default (and updates documentation accordingly).

To get the app running locally you can now just yarn start instead of first having to set up ccdb5-api locally. You can still use a local API if you want by changing the proxy field in package.json.

See DATAP-1268 for context

Changes

  • Local CRA proxy points to cf.gov instead of localhost:8000.

Testing

  • Pull down this branch.
  • yarn start and the app should open and show ~ 5MM complaints.

Checklist

  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the front end playbook
  • Passes all existing automated tests
  • New functions include new tests
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged
  • Visually tested in supported browsers and devices
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

The process of getting ccdb5-ui running locally is overly complex
because it requires a local version of ccdb5-api to also be running
locally. The complaints API is public and contains no PII so it would
be much easier to onboard devs if we used it for local development instead
of forcing them to set up ES.

See DATAP-1268 for context
Copy link
Contributor

@flacoman91 flacoman91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't test this, but this looks good.

Great to not have to load up the ccdb data pipeline for FE work!

Copy link
Contributor

@BrewCityBoy BrewCityBoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Table loaded with 4 million+ records. Works perfectly.

@contolini contolini added this pull request to the merge queue Jan 24, 2024
Merged via the queue into main with commit 29f38e5 Jan 24, 2024
2 checks passed
@contolini contolini deleted the prod-api branch January 24, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants