Fix conflict with filtered dataset export and paginated results #484
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use
frm
andsearch_after
query params to handle paginated search results. But when a user exports a subset of our complaint database, the aforementioned pagination params are sent to the API causing it to throw an error becausefrm mod size != 0
.Instead of reworking the API logic it's better to just purge pagination params from export URLs because they're irrelevant. The whole point of exporting is to download all the search results and not just a single page of search results.
See DATAP-33 for more info and context.
Changes
Testing
yarn test
should passyarn cypress run --browser chrome --headless --config baseUrl=http://localhost:8000/data-research/consumer-complaints/search/
should passNext >
to get to page 2 of results.Export data
Filtered dataset
Start export
400
errorChecklist