Rule to check for writeDump in cfset tags and script blocks

[justinmclean]

No description provided.

[justinmclean]

100% code coverage in unit tests

[ryaneberly]

I think the expression inside cfset gets parsed. As a CFScriptExpression?. Not sure. If not it probably should be.

[justinmclean]

Sadly it doesn't get parsed as a CFScriptExpression. If you comment out that method the test testWriteDumpInTag fails.

[ryaneberly]

@justinmclean
take a look at 2337b8f

I had to dig a little big to remember how this all worked. Not processing sounded like a missing feature, but it is there.

You are correct that
public void expression(final CFScriptStatement expression, final Context context, final BugList bugs)
does not get called for

but

public void expression(final CFExpression expression, final Context context,
final BugList bugs)

gets called for all expressions regardless of whether its from , or even nested inside another expression!

So. the rule becomes quite simple. No substringing required.

[justinmclean]

Great I'll fix - may need to fix a few other rules as well, but that's what's the tests are for :-)

[ryaneberly]

right :-).