-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POM dependency cleanup #338
Merged
TheRealAgentK
merged 12 commits into
cflint:dev
from
stepstone-tech:pom-dependency-cleanup
Jul 11, 2017
Merged
POM dependency cleanup #338
TheRealAgentK
merged 12 commits into
cflint:dev
from
stepstone-tech:pom-dependency-cleanup
Jul 11, 2017
+26
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAR is the default type of dependency, so doesn't need to be specified explicitly.
jUnit is (normally) only used in test phase. Keeping it in the (default) scope of 'compile' will add the dependency to the final package, which is unnecessary.
This is the usual case, where 'test' dependencies are placed at the end of the <dependencies> section.
Ant moved to a different groupId. Updating accordingly.
If we're only invoking maven-compile-plugin to set the target Java version, we might as well do that with the shorter <properties> section.
Since we have a number of dependnencies referencing the same version, it'll be easier to keep them in sync if they're defined in one place.
Since that's the default scope we don't need to specify it explicitly.
- Removing antlr4-runtime and stringtemplate because they're both included in the antlr4 dependencies. - Bumping antlr4 version to 4.7 to match what the cfparser currently uses.
Setting the same version of javolution as the one coming with cfparser. Removes the build warnings from the maven-shade-plugin and ensures the code is running with the same dependency it was compiled.
Bump the version to 1.2, which is what cfparser is using, and replace with the `commons-logging`, without the `-api` suffix, which seems to have been dropped some 10 years ago. This gets rid of the last warnings from maven-shade-plugin.
Thx @mpaluchowski - looks good to me from glancing over it. As soon as @ryaneberly has merged cfparser/cfparser#78 I'll be happy to merge this into dev. |
Aligns versions of some dependencies, most notably ANTLR.
@TheRealAgentK I just updated the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on a similar pull request cfparser/cfparser#78.
Cleaning the POM of obsolete statements, correcting scopes, moving some versions to
<properties>
to make it easier to keep those in line.Importantly aligning a number of dependencies with the versions used by cfparser/cfparser:
org.antlr:antlr4
replaced with 4.7 and removed explicitstringtemplate
andantlr4-runtime
dependencies, since these come with the first packagecommons-logging
to 1.2 andjavolution
to 5.5.1, which is what cfparser/cfparser is using, thus removing uglymaven-shade-plugin
warnings (and hopefully the potential of bugs due to dependency mismatch)This must be merged after cfparser/cfparser#78 and with a new version of cfparser/cfparser included. Otherwise the
antlr4
changes will be breaking.