Provide some rules around naming of variables and methods #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manipulation. added sample parmeter test
|
See the "MinLength" parm I added to the checker and to the test. |
…t for method name rules.
justinmclean
changed the title
|
Refactored a bit and added new rules for method names. Mind double checking the change I made to CFlint.java to fix passing the method / function name about. |
Conflicts: src/main/java/com/cflint/plugins/Context.java
|
CFLint changes look fine. That is to get the function name into the context for the CFFunctionDeclaration itself? |
|
Exactly it needs the function name when parsing the CFFunctionDeclaration. |
|
perfect. thanks |
|
IMO this is good to go now, if no objections I'll merge into dev. |
|
looks good. thanks |
Conflicts: src/main/resources/cflint.definition.xml
justinmclean
added a commit
that referenced
this pull request
Oct 21, 2015
Provide some rules around naming of variables and methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works but still a little more to do. Need to parametrize the rules a little so users can tune them. Any suggestions?