Release 0.5.1-SNAPSHOT

[jjames967]

I'll be committing the changes so far to the master branch and releasing a SNAPSHOT version of it to the Sonar repo. Please log any issues found separately.

[justinmclean]

Do you want me to hold off on new features / merging the current pull requests? Some existing ones require a little clean up but are probably good enough to release.

[ryaneberly]

I'm inclined to include them with the exception of
Added rule to check for repeated hard coded values #94.
I would like to discuss that one further.

The others are tested and working. We can handle cleanup as enhancements.

On Sun, Oct 11, 2015 at 9:44 PM, Justin Mclean [email protected]
wrote:

Do you want me to hold off on new features / merge the current pull
requests? Some existing ones require a little clean up but are probably
good enough to release.

—
Reply to this email directly or view it on GitHub
#97 (comment).

[jjames967]

Already committed to master. If something should be pulled out, please feel free to do so.

[jjames967]

I'll wait on releasing the build.

[ryaneberly]

Thanks @jjames967
Give me a few minutes.

On Sun, Oct 11, 2015 at 10:17 PM, jjames967 [email protected]
wrote:

I'll wait on releasing the build.

—
Reply to this email directly or view it on GitHub
#97 (comment).

[justinmclean]

I'm good with the (minor) clean up after the release for the next release.

[ryaneberly]

Merged justin's contribs except for #94.

release is ready for now. IMO.

On Sun, Oct 11, 2015 at 11:00 PM, Justin Mclean [email protected]
wrote:

I'm good with the (minor) clean up after the release for the next release.

—
Reply to this email directly or view it on GitHub
#97 (comment).

[ryaneberly]

Fixed a few cfparser issues as well. Want to do a release there too?

[jjames967]

Snapshot is finally deployed. There were some issues as my gpg signing specs were deleted from my computer, but I'm hoping the cfparser and cflint changes play okay together. They're both released as snapshots.

[ryaneberly]

forgive the obvious question, but where are the snapshots deployed?

[jjames967]

It's not a dumb question actually. SonaType holds releases inside a separate repo. It doesn't release them to children sites like Maven Central. If pulling from a pom file, you need to specify it's okay to pull from the SNAPSHOT repo.

<profiles>
    <profile>
        <id>allow-snapshots</id>
        <activation><activeByDefault>true</activeByDefault></activation>
        <repositories>
            <repository>
                <id>snapshots-repo</id>
                <url>https://oss.sonatype.org/content/repositories/snapshots</url>
                <releases><enabled>false</enabled></releases>
                <snapshots><enabled>true</enabled></snapshots>
            </repository>
        </repositories>
    </profile>
</profiles>

[jjames967]

I made a comment in the wiki

[ryaneberly]

Thanks!

On Mon, Oct 19, 2015 at 9:32 PM, jjames967 [email protected] wrote:

I made a comment in the wiki

—
Reply to this email directly or view it on GitHub
#97 (comment).

[ryaneberly]

@jjames967 Sorry, there is a bug fix that is a bit glaring under the right cirumstances.

#105
this commit:
d2f86bf

This should probably be included in the release.

[justinmclean]

Hi,

@jjames967 https://github.com/jjames967 Sorry, there is a bug fix that is a bit glaring under the right cirumstances.

Except that it should return 1 not return 0. (Test will fail if it returns 0).

Thanks,
Justin

[ryaneberly]

@justinmclean . Ah right. Thanks!